On Tue, 20 Oct 2026 17:57:29 GMT, Andy Goryachev <[email protected]> wrote:

>> Fixed incorrect handling of the surrogate pairs in `GlyphLayout.breakRuns()`.
>> 
>> The original code erroneously split surrogate pairs when breaking the runs, 
>> which resulted in malformed strings passed onto the platform glyph layout 
>> code.
>> 
>> Reviewers: @prrace @Ziad-Mid 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andy Goryachev has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - review comments
>  - Merge branch 'master' into 8394318.weird
>  - tests
>  - fix

LGTM. The logic looks correct. I verified that the new test fails without and 
passes with the fix. I also manually verified that the text now looks correct 
when rendered into a TextArea.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/2349#pullrequestreview-5894886486

Reply via email to