Review: Needs Fixing 9 build_lyrics_outline_css, Receiver Once space between build_lyrics_outline_css and Receiver.
18 def format_slide(self, words, line_break, forcePage=False): Either "lineBreak" or "force_page", but not one of one standard and one of another please. Also, I'm presuming this is a Python class, in which case you should be using "force_page". In addition to that, you've added the documentation for "line_break" but not "force_page". Please do so. 38 if line_count != -1: Set line_count to "None" on line 48, then you can do a check for "if line_count is not None:" 69 def generate_preview(self, themedata, forcePage=False): Please set "themedata" to "theme_data" and "forcePage" to "force_page" since I'm presuming this is a Python class. 245 def generateImage(self, themedata, forcePage=False): Please change "themedata" to "themeData" Once last thing. If you're using a variable in one method only (I'm not sure if you are, I don't have the full file in front of me), don't bother to set an object-level variable, it's just a waste of memory. (see self.forcePage = forcePage) -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/41784 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
