Review: Needs Fixing I know this is probably old cruft, but please just try to fix things as you see them...
34 + def generateSlideData(self, service_item, item=None, xmlVersion=False) Um, xml_version or serviceItem? Also on lines 83, 216, 229, 242, 264, 304 and 365. 139 + self.hide_mode = None Shouldn't that be self.hideMode? On line 100 yo have u'from_plugin', but on line 105 you have u'xmlVersion'. Choose one please. -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/42017 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
