849     + if not self.edit:
850     +     if not 
self.thememanager.checkIfThemeExists(self.theme.theme_name):
851     +         return

I'm not too sure what's going on here, and I'm worried that something is going 
to slip through the cracks... what happens if the first statement is true, but 
the second is false? Should it just carry on? If they are meant to be used 
together, why not ``and`` them?


-- 
https://code.launchpad.net/~trb143/openlp/next/+merge/45641
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to