Review: Needs Fixing Lines 9 -> 17 need to be moved to the [renamed] webkit display_css() too.
(I'm aware you just copied my function names, but I was just doing some quick examples and not putting any thought into the naming :) A few cosmetics: Delete commented out code: 285,286,300,318,756,1109,1355,1356,1873,1874,2245,2246,2251,2252,2454 Note, if they are commented out because you plan to implement properly in a future commit, just put a # TODO: comment above them, saying what the missing functionality is. We don't like to merge commented out code into trunk. Lines too long: 353, 552 Space needed before the +=: 1269, 1278,1287 Lines 1688 -> 1698: You need a space on both sides of the + or - -- https://code.launchpad.net/~crichter/openlp/media_rewrite/+merge/63916 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
