Review: Needs Fixing The plugin to core code is wrong and I think it is because we have the placement wrong. A lot of the plumbing is because the players are controlled by the plugin and core needs access to them. For presentations this as fine as the players were external but for this it's more complicated. I think Core should provide player services (extensible and flexible so more can be added). This should stop the needed to pass controllers around. The media plugin asks what players can I use and what do I want to us or just does not care and uses what core has decided. I am not sure what will happen if this code has media deactivated.
-- https://code.launchpad.net/~crichter/openlp/media_rewrite/+merge/64630 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
