Review: Needs Fixing

I don't like the SongFormatAttr as a separate class (and I don't like the 
incomplete name), I'd prefer it to be part of SongFormat.

Additionally, if "availability" and co. are supposed to be enumeration items, 
then they should be PascalCase.
-- 
https://code.launchpad.net/~sfindlay/openlp/refactor-song-import/+merge/108170
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to