Review: Needs Fixing

219     +    def on_login(self, username):
220     +        """
221     +        Called on successful login
222     +        """
223     +
224     +    def on_logout(self, username):
225     +        """
226     +        Called on logout
227     +        """

Please at least put "pass" in there.


233     +        return """<html>

We have Mako, please use it for the login page too.
-- 
https://code.launchpad.net/~trb143/openlp/cherrypy/+merge/152779
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to