Review: Needs Fixing

23      - return Settings.__default_settings__[key]
24      + return Settings.__default_settings__.get(key, '')

The reason line 23 (and all the rest like them) was not working was because 
Felipe was doing it wrong. That line MUST fail if you're writing your code 
wrong.

What you need to do is to specify a list of DEFAULT SETTINGS in the 
__default_settings__ dictionary in <blah>plugin.py. See songsplugin.py for an 
example.
-- 
https://code.launchpad.net/~tomasgroth/openlp/better-remote/+merge/211631
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to