Hi, First, I start doing what you suggest me : I revert resources changes for all language. However, I add French translation of the remote plugin (because French user don't read English, sorry). I also remove the jquery.textfill-0.5.1.min.js file, it's a mistake.
Globally, I develop this remote app in the spirit of RIA (Rich Internet Application). In this context, I added new jquery file (I use up to date function of jquery mobile) to start with a good basis and with explicit version of library. I also choose to separate changes in python file by adding function rather than replace body of existing one to avoid crash due to unknown impact. All my modification is in block marked by comments "# mbernis new home remote app BEGIN/END". I do that to isolate my code from yours so that I can merge blindness trunk to my branche. Here are my comments and questions : * About the multiple html file and duplicated code in remote plugin : I didn't want replace the original with mine without your validation, and I wanted to keep the old API functional for iPad and Androïd application. Question 1 : Should I remove files and code of the original remote plugin ihm, or want you keep them ? * The PDF is a simple export of a libreoffice document in order to provide a user guide accessing by client on click over the help icon. I added it because users that connect to the remote app from theirs home don't know OpenLP python app on the server : only 2 users really use the python app, others use only remote app. This PDF is their documentation serve by the server itself. I can remove it and send it by mail to users but, as user, I also appreciate a self documented web app. Perhaps I don't understand what's the problem with this PDF : if it's the PDF format, I can write it in html. Question 2 : Please let me know what is the best solution you think to serve this documentation at end users ? * I also think about future development with a different life cycle between remotes client and OpenLP server (Web client, iPad, Androïd, ...). To easily manage backward compatibility, I added specific function in core that handle remote events with the API version in parameter. I implemented this API version through the routing system of HttpRouter.py. So, new client call new url and old client call old url, but the response can be compute by the same function with less or more return parameters corresponding to the API version. Question 3 : Should I refactor existing function that serve actual remote request (what I will call api_v0) to use new functions ? Finally, about core updates, I added some deep changes to provide a more intuitive usage in the remote web app. For example, when you search verses in Bibles, in the python app, you can choose the Bible version in a list box. When you're on the remote app, you don't : verses are those of the previous selected Bible. But remote users can't change the server list box. To open this functionality, I change Bible plugin so that it search in all Bible version and add this version in the id of search result. Thanks for reading, mbernis. -- https://code.launchpad.net/~mbernis/openlp/trunk_remote_app_enhancement/+merge/233617 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
