-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Somebody in the thread at some point said:
> Andy Green wrote:
>> I think maybe you misunderstood this -- the only edit in there
>
> I guess I wasn't clear :) I spotted the GLAMO entires while looking
> at your patch, that's why I put this there as a reminder, for further
> study.
Nope you weren't clear :-) So my change to that file is fine all around.
>>> should probably be "struct _fiq_ipc". In general, I think we should
>> I think you missed an edit on that line :-)
>
> Ah yes :)
>
>> Fair enough, with the attached patch I changed it to use fiq_ipc_t which
>> is the method used in plenty of other places in the kernel
>
> Ick. "struct foo_t" ain't right. There's a lot of it in the Atheros
> code, but that's all. (And that one has special dispension for not
> following any coding style right now, because we all know that it'll
> eventually get torn to pieces by the sharks on linux-kernel anyway ;-)
linux-wireless will get it first, and believe me they can be tough
cookies because they don't want to get blamed for handing crap to their
upstream.
> "foo_t" is actually reserved by POSIX, so even the common practice of
> mimicking the way how "standard" typedef'ed types are named is
> questionable at best. (And clearly wrong in user space.)
Well I even grepped for it in the sources before suggesting it, just to
"make sure". But in fact despite a ton of hits it isn't really used for
local struct names in there, just on structs inherited from userspace
includes :-/ Plenty of it around though, plenty of the _type convention
around too.
> So, how about just "struct fiq_ipc" ?
Huh... obvious.
- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFHoxmWOjLpvpq7dMoRAtJ0AJ0YLYT2pFztulemrtB1niz1rciBMgCfXLLw
y5/pznUEErnaO8XGIfMtzqs=
=73Yc
-----END PGP SIGNATURE-----
clean-fiq.patch
Change ipc struct type from _fiq_ipc to fiq_ipc
From: Andy Green <[EMAIL PROTECTED]>
Signed-off-by: Andy Green <[EMAIL PROTECTED]>
---
arch/arm/mach-s3c2440/mach-gta02.c | 2 +-
include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-s3c2440/mach-gta02.c b/arch/arm/mach-s3c2440/mach-gta02.c
index 763831b..4550e31 100644
--- a/arch/arm/mach-s3c2440/mach-gta02.c
+++ b/arch/arm/mach-s3c2440/mach-gta02.c
@@ -89,7 +89,7 @@
* the definition in there and include the same definition in your kernel
* module that wants to interoperate with your FIQ code.
*/
-struct _fiq_ipc fiq_ipc;
+struct fiq_ipc fiq_ipc;
EXPORT_SYMBOL(fiq_ipc);
#define DIVISOR_FROM_US(x) ((x) << 1)
diff --git a/include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h b/include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h
index b590c17..286ad34 100644
--- a/include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h
+++ b/include/asm-arm/arch-s3c2410/fiq_ipc_gta02.h
@@ -20,7 +20,7 @@
#include <asm/plat-s3c/regs-timer.h>
-struct _fiq_ipc {
+struct fiq_ipc {
/* vibrator */
unsigned long vib_gpio_pin; /* which pin to meddle with */
u8 vib_pwm; /* 0 = OFF -- will ensure GPIO deasserted and stop FIQ */
@@ -28,7 +28,7 @@ struct _fiq_ipc {
};
/* actual definition lives in arch/arm/mach-s3c2440/fiq_c_isr.c */
-extern struct _fiq_ipc fiq_ipc;
+extern struct fiq_ipc fiq_ipc;
extern unsigned long _fiq_count_fiqs;
extern void fiq_kick(void); /* provoke a FIQ "immediately" */
