Hi, Aliaksandr, Yes, it is clear to me now, and I could even learn from it. The hierarchy is complex, and a naming convention is really important here. The diagram helps and we can use it for reference in the future.
Thanks, William On Sun, Jan 22, 2012 at 6:41 PM, Aliaksandr Autayeu <[email protected]>wrote: > Hi all, > > I have just committed the improvement for OPENNLP-402, which should make it > much easier to understand the class structure of the cmdline package. > Naming, javadocs, and the class hierarchy is improved. > > Can you take a look at the comment: > > https://issues.apache.org/jira/browse/OPENNLP-402?focusedCommentId=13190767#comment-13190767 > and > the diagram: > > https://issues.apache.org/jira/secure/attachment/12511441/opennlp-cmdline-package-class-structure.png > and > let me know whether it is clearer now? Thank you! > > William, I would appreciate if you give it a look, since you asked above. > > Aliaksandr > > On Sun, Jan 22, 2012 at 7:24 PM, [email protected] < > [email protected]> wrote: > > > Thank you, Aliaksandr, > > > > I really like how we can use stream factories during training and > > evaluating tools. The changes you did are great. > > I don't know if we need to improve the documentation. The code looks > > good. Now I understand it better with your commit to fix this issue. > > > > Thanks > > William > > > > On Sun, Jan 22, 2012 at 8:56 AM, Aliaksandr Autayeu > > <[email protected]> wrote: > > > Hi William! > > > > > > Thank you for pointing this out. I have fixed it. Can you check and > close > > > the issue? > > > > > > How can I improve the documentation (or the code itself) so that the > new > > > code is easier to understand? Any advice? > > > > > > Aliaksandr > > > > > > On Thu, Jan 19, 2012 at 2:57 PM, [email protected] < > > > [email protected]> wrote: > > > > > >> Aliaksandr, > > >> > > >> Could you also check the issue > > >> https://issues.apache.org/jira/browse/OPENNLP-418 ? I tried to fix it > > >> by myself but I could not find an appropriate solution. I still have > > >> to better understand the new code. > > >> > > >> Thank you, > > >> William > > >> > > >> > > >> On Wed, Jan 18, 2012 at 7:34 AM, Jörn Kottmann <[email protected]> > > wrote: > > >> > On 1/18/12 1:05 AM, James Kosin wrote: > > >> >> > > >> >> I put the TODO there; because I couldn't determine if it was a > better > > >> >> place. The only big downside to using the Stream is we have no > > control > > >> >> over the encoding. So, I was thinking more that this method of > > loading > > >> >> the item would be deprecated anyway. In favor of the other method. > > >> > > > >> > > > >> > Decoding with the correct encoding is the responsibility of the > > >> > Reader. There is no need to pass an encoding along in this method, > > right? > > >> > > > >> > Jörn > > >> > > >
