[ 
https://issues.apache.org/jira/browse/OPENNLP-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148358#comment-13148358
 ] 

Joern Kottmann commented on OPENNLP-368:
----------------------------------------

Reviewed parts of the patch. Looks good, but we need to have a good test 
coverage of the code we change.
Did you do any testing?

Do you have this in a git branch? So we could delay and change it easily?
                
> loops improved in opennlp-tools
> -------------------------------
>
>                 Key: OPENNLP-368
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-368
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: tools-1.5.3-incubating
>            Reporter: Aliaksandr Autayeu
>            Priority: Minor
>              Labels: patch
>         Attachments: 0008-loops-improved-in-tools.patch
>
>
> Many old-style indexed loops replaced with Java5 for each loops to improve 
> code readability and reduce possibility of bugs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to