[ 
https://issues.apache.org/jira/browse/OPENNLP-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148415#comment-13148415
 ] 

Aliaksandr Autayeu commented on OPENNLP-368:
--------------------------------------------

Exactly, to avoid getting something unexpected.

I am a little worried that the patch might introduce bugs, which could be
OK. Can you elaborate on "extensive testing". In short, how can I prove
it's OK to apply this simple refactoring?

In other parts we have good junit test coverage, there it would be safe to

 It would be good, if applied at least partially. The more accurate the
code is - the better.

Aliaksandr

                
> loops improved in opennlp-tools
> -------------------------------
>
>                 Key: OPENNLP-368
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-368
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: tools-1.5.3-incubating
>            Reporter: Aliaksandr Autayeu
>            Priority: Minor
>              Labels: patch
>         Attachments: 0008-loops-improved-in-tools.patch
>
>
> Many old-style indexed loops replaced with Java5 for each loops to improve 
> code readability and reduce possibility of bugs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to