[
https://issues.apache.org/jira/browse/OPENNLP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156703#comment-13156703
]
Joern Kottmann commented on OPENNLP-402:
----------------------------------------
Here are my code review comments:
- Remove author tags, code is owned by the community and not individuals, we
list contributors and committers on the team page.
- Don't rename classes which are part of our public API, breaks backward
compatibility (NameSampleDataStream, WordTagSampleStream)
- Should AbstractCLITool.getHelp return this: "Usage: " + CLI.CMD + " " +
getName() ?
- Why was InvalidFormatException removed from some ModelLoader sub-classes?
- Documentation should be updated as well
> CLI tools and formats refactored
> --------------------------------
>
> Key: OPENNLP-402
> URL: https://issues.apache.org/jira/browse/OPENNLP-402
> Project: OpenNLP
> Issue Type: Improvement
> Components: Command Line Interface, Formats
> Affects Versions: tools-1.5.3-incubating
> Reporter: Aliaksandr Autayeu
> Labels: patch
> Attachments: 0016-CLI-tools-and-formats-refactored.patch
>
>
> Proposed patch refactors CLI tools and simplifies the code by introducing
> hierarchy and removing a lot of code duplication. It also introduces better
> error and help messages, including help for formats and listing available
> formats in various tools, which are now able to work with formats directly.
> This, in turn, eliminates the need to keep converted files on disk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
