Hello Christian,

I understand the change for parse or link error events but it sounds strange to 
me for request done event, as I think that a request done is linked to client 
or 
server mode.

For example in the obex_test sample.
In client mode, after each OBEX request a call to syncwait() (in 
apps/obext_test_client.c) is made to wait for request done event.
This event is dispatched in obex_event() (in apps/obex_test.c) based on mode 
parameter (set by obex_deliver_event() (in lib/obexmain.c) based on state 
value).
For client, it should call client_done() (in apps/obext_test_client.c) to break 
the loop in syncwait().
But with the new behavior, request done event is always dispatched to server 
side function server_done() and client loop in syncwait() does not stop.

For me there are 2 alternatives:
- the sample application should be updated, as with new behavior it will not 
unblock the OBEX_HandleInput loop
- or something like my patch should be applied to the library.

Regards

Fred

Christian W. Zuckschwerdt wrote:
> Hi Frederic,
> 
> Marcel modified the behaviour on 2006-08-28 to be more consistent.
> 
> See: "Reset the state before calling the event callback "
> http://dev.zuckschwerdt.org/openobex/changeset/258/trunk/lib/obex_client.c
> 
> and "Make sure self->state is correct before calling obex_deliver_event()"
> http://dev.zuckschwerdt.org/openobex/changeset/262/trunk/lib/obex_client.c
> 
> Your patch looks good, if the "old" behaviour is intended. Can you look
> through the above changes and compare them to what you expect?
> 
> 
> regards,
> Christian
> 
> Frederic Danis schrieb:
>> In client mode, after connection request it receives an
>> OBEX_EV_REQDONE with mode set to OBEX_MODE_SERVER while I am waiting
>> for OBEX_MODE_CLIENT (as previously and in obex_event() function of
>> apps/obex_test.c).
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Openobex-users mailing list
> Openobex-users@lists.sourceforge.net
> http://lists.sourceforge.net/lists/listinfo/openobex-users


-- 
-----------------------------------------------
It is not by improving the oil lamp that one invents the electric bulb!
-----------------------------------------------
Danis Frederic                   Access Company
Software engineer
Mail : mailto:[EMAIL PROTECTED]
-----------------------------------------------

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to