I hadn't seen the "Creating/submitting a patch" page on www.openobex.com so I did the patch again using svn diff (attached).
I tried to register on www.openobex.com to file a new ticket, but it doesn't seem to work. The created account is not recognized (it exists though, as I got an "already existing account" when I tried to create it again). I don't see any place where I can say "password lost" (in case I mistyped the password twice), so I tried again with a second account, and same result. Without login in, it seems not possible to create a ticket. Eric. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Hendrik Sattler Sent: jeudi 3 janvier 2008 20:26 To: openobex-users@lists.sourceforge.net Subject: Re: [openobex-users] OBEX_EV_REQDONE mode problem in cvs version Am Donnerstag 03 Januar 2008 schrieb Eric Lapuyade: > What I expect to happen is that someone responsible for OpenObex comment > on my proposition, and validate it or not. >From my POV, the changes make sense, didn't get too deep though. One comment, though: the (x? a: b) thing is repeated way too often. I'd suggest using a wrapper function for this case (or a #define), preferable with the old name (makes the patch a lot smaller and hides details) and call the function with the additional argument only for the cases where the mode is known better from the caller. Like obex_deliver_event() stays unchanged (no mode argument) and calls obex_deliver_event_ext() with the new mode argument (I am not good in naming functions :-/ ). > I have attached a patch file. The modifications have been tested > successfully. > > I have also submitted a bug on sourceforge tracker for OpenObex. I hope > this is what you expect. Nah, use trac on www.openobex.org. The SF.net site has pretty low usability and zany prefers the trac one, I guess. Small and good changes/fixes usually make it in but patience is a requirement (e.g. the developers with CVS access can be very busy with real life). HS ------------------------------------------------------------------------ - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
deliverevent_svn.patch
Description: deliverevent_svn.patch
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
