2009/2/10 Hendrik Sattler <p...@hendrik-sattler.de>: >> And here are the patches that I've accumulated - the first two revert >> the revert of USB service descriptor patch that broke the ABI, then >> there are FreeBSD fixes, and the USB API change (both previously sent >> to the list), 0005 adds support for libusb 1.0 (libusb 0.x support >> remains, via ifdefs), and 0006 adds USB vendor/product ids and >> bus/device/interface numbers to USB OBEX interface API. > > Please merge path 0001 and 0002. This patch should then also update the > API version at least for libtool. I'll handle the cmake updates if you > don't do it.
Er, I thought that Marcel would do the API version update - anyway, just to be sure, how should it look like? > Why are you changing from char* to unsigned char* in obex_const.h? If > those are strings, they should stay as char*, even when they are UTF-8 > (or other 8-bit) strings. If you say they are 8bit binary data, use > uint8_t*. Just to be consistent with libusb 1.x, which is using unsigned char: http://libusb.sourceforge.net/api-1.0/group__desc.html#gf3f92d0a7465d49a5e61eb3f8689fae4 I can revert to char*, no problem. > Defining also HAVE_USB when you define HAVE_USB1 saves you from changing > all those defines. You should assume in the code that the build system > will only compile one in, either usb1obex.c or usbobex.c. > You should thus also remove teh #ifndef _WIN32 in usb1obex.c. Sure, will fix. > BTW: Is the split in two different files really necessary? Yes, I think so. Libusb 1.x has changed the names of all structs and functions and those are scattered all over usbobex.c I will redo the patches after I get further comments from you. -- Alexander ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
