Am Dienstag 10 Februar 2009 16:33:01 schrieb Marcel Holtmann:
> > > BTW: you can find all my changes to openobex-1.5 at
> > >  http://gitorious.org/projects/openobex/repos/mainline/logs/updates
> > >
> > > Only small fixes, including the version number patch.
> >
> > And here are the patches that I've accumulated - the first two revert
> > the revert of USB service descriptor patch that broke the ABI, then
> > there are FreeBSD fixes, and the USB API change (both previously sent
> > to the list), 0005 adds support for libusb 1.0 (libusb 0.x support
> > remains, via ifdefs), and 0006 adds USB vendor/product ids and
> > bus/device/interface numbers to USB OBEX interface API.
>
> I did revert two USB changes from you already. Which ones are these?

0001 and 0002, with the updated patchset 0001 only.

> And please either have me pull from a GIT repository or send one patch
> per email. Makes it a lot easier to review and apply cleanly. I wanna
> make sure that the author information stay the same and not get changed
> to me. If I have to touch a patch, I don't bother to make sure that the
> authorship stays correct. Last editor wins ;)

I pushed them to the 'usb' branch in my repository at gitorious. Not yet 
reviewed, you can pull that branch from
  git://gitorious.org/openobex/mainline.git
The patches had the proper headers, so git am worked fine, except one
Applying Added support for libusb 1.0                                          
.dotest/patch:95: trailing whitespace.                                         
PREDEFINED             = "LIB_SYMBOL=" "CALLAPI=" 
"OPENOBEX_SYMBOL(retval)=retval" HAVE_IRDA HAVE_USB HAVE_USB1 HAVE_BLUETOOTH
warning: 1 line adds whitespace errors.                                         
                                              

Maybe Alex can fix that. But that should make review fairly easy for you :)

HS


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to