Zitat von Johan Hedberg <johan.hedb...@gmail.com>: > Hi Iain, > > On Tue, Jun 21, 2011, Iain Hibbert wrote: >> we only need to detect the presence of "Bluetooth Device Address" type >> in order to provide the function prototype, which needs to be from a header >> included prior to <openobex/obex.h> >> >> while here constify arguments >> --- >> include/openobex/obex.h | 25 ++++++++++++++++--------- >> lib/obex.c | 6 +++--- >> 2 files changed, 19 insertions(+), 12 deletions(-) > > I've applied patches 1-4 but had to stop at this one. Firstly, this > should really be split into two separate ones (the way you've formatted > the commit message already gives hints about it). Secondly, only > recently Marcel objected to a patch which would break the API (the one > about packet based transports). Doesn't adding const declarations have a > similar implication?
Not in C, only in C++, as C is not using name mangling. For a C compiler, the const only tells him that the value doesn't change. That allows it to optimize. However, there is no ABI difference. > Btw, please start your summary lines and sentences with capital letters. > I had to fix that manually in patches 1-4. Did you see the mail about Nami's 3 patches (the ones that do not break the API)? BTW: my L2CAP patch set also modifies the last argument of BtOBEX functions from uint8_t to uint16_t. However, after reconsidering, this may be a problem for big-endian systems. Shall the L2CAP transport use separate functions, then? I actually didn't want to but... Note that for version 2.0, we already changed the API/ABI by removing deprecated stuff. Marcel comment was not actually about full API compatibility but being able to write code that compiles with both versions, 1.5 and 2.0. HS ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
