On Tue, 28 Jun 2011, Johan Hedberg wrote: > Hi Iain, > > On Tue, Jun 21, 2011, Iain Hibbert wrote: > > we only need to detect the presence of "Bluetooth Device Address" type > > in order to provide the function prototype, which needs to be from a header > > included prior to <openobex/obex.h> > > > > while here constify arguments > > --- > > include/openobex/obex.h | 25 ++++++++++++++++--------- > > lib/obex.c | 6 +++--- > > 2 files changed, 19 insertions(+), 12 deletions(-) > > I've applied patches 1-4 but had to stop at this one. Firstly, this > should really be split into two separate ones (the way you've formatted > the commit message already gives hints about it). Secondly, only > recently Marcel objected to a patch which would break the API (the one > about packet based transports). Doesn't adding const declarations have a > similar implication?
Ok thanks, I agree with Hendrik - it does not change anything for C but it does fix a problem, as on NetBSD at least BDADDR_ANY has always been defined as a const value.. On reflection, I split that patch into three.. 1. change the bdaddr_t to bt_addr_t in order to be consistent 2. constify prototype 3. define bt_addr_t in a better way > Btw, please start your summary lines and sentences with capital letters. > I had to fix that manually in patches 1-4. ok did that too, so six patches to follow iain ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
