Hello everybody.
I think I found memory leak in OpenOCD code and want to sent a patch.
Following instructions in HACKING file I created Gerrit account, set my name
and
e-mail in git:
$ git config -l
user.name=Sergey A. Borshch
user.email=sb...@users.sourceforge.net
checkpatch.sh says my patch is correct:
$ tools/checkpatch.sh
total: 0 errors, 0 warnings, 21 lines checked
Your patch has no obvious style problems and is ready for submission.
But I'm unable to send the path:
$ git push review
Counting objects: 9, done.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 584 bytes, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
To ssh://sb...@openocd.zylin.com:29418/openocd.git
! [remote rejected] HEAD -> refs/publish/master (not Signed-off-by
author/committer/uploader)
error: failed to push some refs to
'ssh://sb...@openocd.zylin.com:29418/openocd.git'
here is the output of git format-patch:
$ git format-patch -M --stdout ${1:-HEAD^}
From fb323dde6a8672a92f6a9235ee7c0a70de783f72 Mon Sep 17 00:00:00 2001
From: Sergey Borshch <sb...@users.sourceforge.net>
Date: Wed, 19 Sep 2012 10:07:36 +0300
Subject: [PATCH] fix memory leaks
if add_connection() fails, memory allocated in copy_command_context() is lost.
Signed-off-by: Sergey Borshch <sb...@users.sourceforge.net>
Change-Id: I91a2757f29612038031eb8953100faa3b850d3a6
What's wrong, how can I fix that?
--
Regards,
Sergey A. Borshch mailto: sb...@sourceforge.net
SB ELDI ltd. Riga, Latvia
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
