On 19.09.2012 11:19, Spencer Oliver wrote:
> On 19 September 2012 08:21, Sergey A. Borshch
> <sb...@users.sourceforge.net> wrote:
>> Hello everybody.
>>
>> I think I found memory leak in OpenOCD code and want to sent a patch.
>>
>> Following instructions in HACKING file I created Gerrit account, set my name
>> and
>> e-mail in git:
>>
>> $ git config -l
>> user.name=Sergey A. Borshch
>> user.email=sb...@users.sourceforge.net
>>
>> checkpatch.sh says my patch is correct:
>>
>> $ tools/checkpatch.sh
>> total: 0 errors, 0 warnings, 21 lines checked
>>
>> Your patch has no obvious style problems and is ready for submission.
>>
>> But I'm unable to send the path:
>>
>> $ git push review
>> Counting objects: 9, done.
>> Compressing objects: 100% (5/5), done.
>> Writing objects: 100% (5/5), 584 bytes, done.
>> Total 5 (delta 4), reused 0 (delta 0)
>> remote: Resolving deltas: 100% (4/4)
>> remote: Processing changes: refs: 1, done
>> To ssh://sb...@openocd.zylin.com:29418/openocd.git
>> ! [remote rejected] HEAD -> refs/publish/master (not Signed-off-by
>> author/committer/uploader)
>> error: failed to push some refs to
>> 'ssh://sb...@openocd.zylin.com:29418/openocd.git'
>>
>> here is the output of git format-patch:
>>
>> $ git format-patch -M --stdout ${1:-HEAD^}
>> From fb323dde6a8672a92f6a9235ee7c0a70de783f72 Mon Sep 17 00:00:00 2001
>> From: Sergey Borshch <sb...@users.sourceforge.net>
>> Date: Wed, 19 Sep 2012 10:07:36 +0300
>> Subject: [PATCH] fix memory leaks
>>
>> if add_connection() fails, memory allocated in copy_command_context() is
>> lost.
>>
>> Signed-off-by: Sergey Borshch <sb...@users.sourceforge.net>
>>
>> Change-Id: I91a2757f29612038031eb8953100faa3b850d3a6
>>
>>
>> What's wrong, how can I fix that?
>>
>> --
>
> try putting signed off line after changeid
even worse:
$ git push review
Counting objects: 9, done.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 586 bytes, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote: ERROR: missing Change-Id in commit message
remote: Suggestion for commit message:
remote: fix memory leaks
remote:
remote: if add_connection() fails, memory allocated in copy_command_context()
is
lost.
remote:
remote: Change-Id: I91a2757f29612038031eb8953100faa3b850d3a6
remote:
remote: Signed-off-by: Sergey Borshch <sb...@users.sourceforge.net>
remote:
remote: Change-Id: Ife89d5d93480934122ec1464981a2900aaf45c11
remote: Hint: A potential Change-Id was found, but it was not in the footer of
the commit message.
To ssh://sb...@openocd.zylin.com:29418/openocd.git
! [remote rejected] HEAD -> refs/publish/master (missing Change-Id in commit
message)
error: failed to push some refs to
'ssh://sb...@openocd.zylin.com:29418/openocd.git'
--
Regards,
Sergey A. Borshch mailto: sb...@sourceforge.net
SB ELDI ltd. Riga, Latvia
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
