This is an automated email from Gerrit.

Sergey Borshch ([email protected]) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/836

-- gerrit

commit 6e48c6764d4180d5962a1a1a430b8ddff4ff2527
Author: Sergey Borshch <[email protected]>
Date:   Wed Sep 19 10:07:36 2012 +0300

    fix memory leaks
    
    if add_connection() fails, memory allocated in copy_command_context() is 
lost.
    
    Signed-off-by: Sergey Borshch <[email protected]>
    Change-Id: I91a2757f29612038031eb8953100faa3b850d3a6

diff --git a/src/server/server.c b/src/server/server.c
index 96f06b3..1499e73 100644
--- a/src/server/server.c
+++ b/src/server/server.c
@@ -85,6 +85,7 @@ static int add_connection(struct service *service, struct 
command_context *cmd_c
                if (retval != ERROR_OK) {
                        close_socket(c->fd);
                        LOG_ERROR("attempted '%s' connection rejected", 
service->name);
+                       command_done(c->cmd_ctx);
                        free(c);
                        return retval;
                }
@@ -104,6 +105,7 @@ static int add_connection(struct service *service, struct 
command_context *cmd_c
                retval = service->new_connection(c);
                if (retval != ERROR_OK) {
                        LOG_ERROR("attempted '%s' connection rejected", 
service->name);
+                       command_done(c->cmd_ctx);
                        free(c);
                        return retval;
                }
@@ -124,6 +126,7 @@ static int add_connection(struct service *service, struct 
command_context *cmd_c
                retval = service->new_connection(c);
                if (retval != ERROR_OK) {
                        LOG_ERROR("attempted '%s' connection rejected", 
service->name);
+                       command_done(c->cmd_ctx);
                        free(c);
                        return retval;
                }

-- 

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to