This is an automated email from Gerrit.

Spencer Oliver ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/1554

-- gerrit

commit d67d082277a0387fd0fccdbf4122777998742f2b
Author: Spencer Oliver <[email protected]>
Date:   Fri Aug 16 15:37:32 2013 +0100

    gdb server: do not free tdesc_filename early
    
    Issue caught by clang.
    
    Change-Id: I4fb331574512140b36e56b3b7ab7e8bdad5e013d
    Signed-off-by: Spencer Oliver <[email protected]>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 48015ab..ab7d40d 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -2936,16 +2936,16 @@ COMMAND_HANDLER(handle_gdb_save_tdesc_command)
 
        int retval = fileio_open(&fileio, tdesc_filename, FILEIO_WRITE, 
FILEIO_TEXT);
 
-       free(tdesc_filename);
-
        if (retval != ERROR_OK) {
                LOG_WARNING("Can't open %s for writing", tdesc_filename);
+               free(tdesc_filename);
                return ERROR_FAIL;
        }
 
        retval = fileio_write(&fileio, tdesc_length, tdesc, &size_written);
 
        fileio_close(&fileio);
+       free(tdesc_filename);
 
        if (retval != ERROR_OK) {
                LOG_WARNING("Error while writing the tdesc file");

-- 

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to