This is an automated email from Gerrit.
Hsiangkai Wang (hsiang...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/1606
-- gerrit
commit a963d75d5bdc36d53948db939ae78314d6bcee88
Author: Hsiangkai Wang <hsiang...@gmail.com>
Date: Fri Aug 30 13:18:54 2013 +0800
target: Make profiling function more readable
Change variable name 'length' to 'numBuckets'. It is more readable.
Change-Id: I913cba0746f887adf6da401a46cd5e9ea88d2c6d
Signed-off-by: Hsiangkai Wang <hsiang...@gmail.com>
diff --git a/src/target/target.c b/src/target/target.c
index 29a011c..72339a1 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -3444,19 +3444,19 @@ static void writeGmon(uint32_t *samples, uint32_t
sampleNum, const char *filenam
assert(addressSpace >= 2);
static const uint32_t maxBuckets = 16 * 1024; /* maximum buckets. */
- uint32_t length = addressSpace;
- if (length > maxBuckets)
- length = maxBuckets;
- int *buckets = malloc(sizeof(int)*length);
+ uint32_t numBuckets = addressSpace;
+ if (numBuckets > maxBuckets)
+ numBuckets = maxBuckets;
+ int *buckets = malloc(sizeof(int) * numBuckets);
if (buckets == NULL) {
fclose(f);
return;
}
- memset(buckets, 0, sizeof(int) * length);
+ memset(buckets, 0, sizeof(int) * numBuckets);
for (i = 0; i < sampleNum; i++) {
uint32_t address = samples[i];
long long a = address - min;
- long long b = length - 1;
+ long long b = numBuckets - 1;
long long c = addressSpace - 1;
int index_t = (a * b) / c; /* danger!!!! int32 overflows */
buckets[index_t]++;
@@ -3465,7 +3465,7 @@ static void writeGmon(uint32_t *samples, uint32_t
sampleNum, const char *filenam
/* append binary memory gmon.out &profile_hist_hdr
((char*)&profile_hist_hdr + sizeof(struct gmon_hist_hdr)) */
writeLong(f, min); /* low_pc */
writeLong(f, max); /* high_pc */
- writeLong(f, length); /* # of samples */
+ writeLong(f, numBuckets); /* # of buckets */
writeLong(f, 100); /* KLUDGE! We lie, ca. 100Hz
best case. */
writeString(f, "seconds");
for (i = 0; i < (15-strlen("seconds")); i++)
@@ -3474,9 +3474,9 @@ static void writeGmon(uint32_t *samples, uint32_t
sampleNum, const char *filenam
/*append binary memory gmon.out profile_hist_data (profile_hist_data +
profile_hist_hdr.hist_size) */
- char *data = malloc(2 * length);
+ char *data = malloc(2 * numBuckets);
if (data != NULL) {
- for (i = 0; i < length; i++) {
+ for (i = 0; i < numBuckets; i++) {
int val;
val = buckets[i];
if (val > 65535)
@@ -3485,7 +3485,7 @@ static void writeGmon(uint32_t *samples, uint32_t
sampleNum, const char *filenam
data[i * 2 + 1] = (val >> 8) & 0xff;
}
free(buckets);
- writeData(f, data, length * 2);
+ writeData(f, data, numBuckets * 2);
free(data);
} else
free(buckets);
--
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
