This is an automated email from Gerrit.

Hsiangkai Wang (hsiang...@gmail.com) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/1608

-- gerrit

commit 064268df9ba5cf3326af9ea015f8a2833276fe4e
Author: Hsiangkai Wang <hsiang...@gmail.com>
Date:   Fri Aug 30 13:45:42 2013 +0800

    target: increase the maximum number of buckets
    
    I do not know what is the reasonable number of buckets.
    If there are enough buckets, the result will be accurate.
    
    I propose increase the maximum number of buckets to 128K.
    If the size of program text section is less than 256KB, every
    two bytes will be occupied by one buckets.
    (The minimum size of one buckets is 2 bytes in gprof implementation.)
    
    Change-Id: If9147743cefdc36f40f21e6dc73b9b28f28c9e1e
    Signed-off-by: Hsiangkai Wang <hsiang...@gmail.com>

diff --git a/src/target/target.c b/src/target/target.c
index 94520f0..cf745a0 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -3447,7 +3447,9 @@ static void writeGmon(uint32_t *samples, uint32_t 
sampleNum, const char *filenam
        int addressSpace = max - min;
        assert(addressSpace >= 2);
 
-       static const uint32_t maxBuckets = 16 * 1024; /* maximum buckets. */
+       /* FIXME: What is the reasonable number of buckets?
+        * The profiling result will be more accurate if there are enough 
buckets. */
+       static const uint32_t maxBuckets = 128 * 1024; /* maximum buckets. */
        uint32_t numBuckets = addressSpace;
        if (numBuckets > maxBuckets)
                numBuckets = maxBuckets;

-- 

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to