Hi, On Tue, Sep 16, 2014 at 04:31:27PM +0800, Simon Qian wrote: > I tried to commit the patch for versaloon performance, when running > checkpatch.sh, it says: > ERROR: Missing Signed-off-by: line(s) > total: 1 errors, 0 warnings, 86 lines checked > Your patch has style problems, please review. > What does this mean?
It means you should run "git commit --amend -s" once so git adds a Signed-off-by line into the commit message. In the future, just use git commit -s for all new patches. S-o-b line basically means you're sure this code you're contributing can be legally shared under an appropriate free software license. See [1] for more. [1] https://www.kernel.org/doc/Documentation/SubmittingPatches Were you able to log in to Gerrit using your new OpenID identity? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:[email protected] ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce. Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
