OK, fixed, I have pushed the patch.
BTW, I received a Nuvoton NUC422 board and seems has some conflicts
with OpenOCD, I'll later check the reason when I have time.
[email protected]
From: Simon Qian
Date: 2014-09-16 21:33
To: Freddie Chopin; openocd-devel
Subject: Re: Re: [OpenOCD-devel] What does Missing Signed-off-by: line(s) mean?
Thanks, it works, but after I "git push review", it says:
simon@simon-VAIO ~/openocd/openocd
$ ls .git/hooks
applypatch-msg.sample post-receive.sample pre-rebase.sample
commit-msg post-update.sample prepare-commit-msg.sample
commit-msg.sample pre-applypatch.sample update.sample
post-commit.sample pre-commit.sample
simon@simon-VAIO ~/openocd/openocd
$ git push review
Counting objects: 11, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 656 bytes, done.
Total 6 (delta 5), reused 0 (delta 0)
remote: Resolving deltas: 100% (5/5)
remote: Processing changes: refs: 1, done
remote: ERROR: missing Change-Id in commit message footer
remote: Suggestion for commit message:
remote: improve the performance for versaloon when using swd, versaloon
firmware
has been updated for reporting errors if fail on swd transactions.
remote:
remote: Signed-off-by: Simon Qian <[email protected]>
remote:
remote: Change-Id: I1a3aa8ca46b14d4abf94875d173fda0a2649d996
remote:
remote: Hint: To automatically insert Change-Id, install the hook:
remote: gitdir=$(git rev-parse --git-dir); scp -p -P 29418 [email protected]
ylin.com:hooks/commit-msg ${gitdir}/hooks/
remote:
remote:
To ssh://[email protected]:29418/openocd.git
! [remote rejected] HEAD -> refs/publish/master (missing Change-Id in commit me
ssage footer)
error: failed to push some refs to
'ssh://[email protected]:29418/open
ocd.git'
I have installed the commit-msg hook, but still the Change-Id is not
automatically
inserted. How to fix it?
[email protected]
From: Freddie Chopin
Date: 2014-09-16 17:10
To: openocd-devel
Subject: Re: [OpenOCD-devel] What does Missing Signed-off-by: line(s) mean?
W dniu 2014-09-16 10:31, Simon Qian pisze:
> Hi.
> I tried to commit the patch for versaloon performance, when running
> checkpatch.sh, it says:
> ERROR: Missing Signed-off-by: line(s)
> total: 1 errors, 0 warnings, 86 lines checked
> Your patch has style problems, please review.
>
> What does this mean?
Commit message of your patch should have:
Signed-off-by: Your Name <[email protected]>
at the end. This is some kind of GPL legality. git can add such line
automatically if you commit with "git commit --signoff".
http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for
Regards,
FCh
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
