Peter, Sounds good to me, does the breakdown of the in terms of order seem ok. Basically, I took about 95% of the m4k code and moved the common code to a new file that both the m4k and microAptiv will use. So I just gutted mips_m4k.c and only keep m4k specific code. Just trying to make the review easier by staging the release of the common code first. No problems on the build side, I will make sure it a clean build across the commits.
Kent -----Original Message----- From: Peter Stuge [mailto:[email protected]] Sent: Friday, October 24, 2014 4:09 PM To: [email protected] Subject: Re: [OpenOCD-devel] Pushing major patch Kent Brinkley wrote: > would like to get feedback if this is the way I should stage the release. You should have a local branch with several commits on top of the latest commit in origin/master. Each commit should make one logical change to the codebase. The codebase should build and work at each commit. Each commit should have a useful commit message. Then you push the branch to gerrit, which makes each commit available for independent review. //Peter ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
