On Fri, Oct 24, 2014 at 10:18 PM, Kent Brinkley <[email protected]> wrote:
> I was thinking of a staged push, where I push the new common code source > first before pushing the m4k changes. My thinking is this would make the > review process easier but would like to get feedback if this is the way I > should stage the release. > > If you move code you should have the addition and the deletion in the same commit, so it's clear where the code is coming from. If at all possible, move code in a separate commit, before any functional changes, so it's easier to review the functional changes. A commit that only moves existing code around doesn't need much, if any, code review. Basically if it builds it should be OK. So it's preferable to not mix such changes with stuff that needs detailed code review. /Andreas
------------------------------------------------------------------------------
_______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
