On Fri, Oct 17, 2014 at 9:17 PM, Kent Brinkley <[email protected]> wrote:
> Hi All, > > > > I wanted to get some feedback on releasing support for the Mips microAptiv > uC and uP (m14k and m14kc) cores before pushing it out. In order to > leverage off the existing m4k code base, I am looking a creating a > mips_common.c which will contain common functions to both m4k and m14 > cores. This is based on similar work done to support the arm7 and arm9 > cores. I would create the m14k (microAptiv) target which would contain > only the necessary functions to support the m14k and use the functions in > common to support common functionality between both core. My main concern > this the current mips4k.c source would have a major reduction of code this > make for a large patch. So is this going to be a big deal or is this > acceptable? > > > There are not many active developers that know their way around the Mips code in OpenOCD, unfortunately. There are already several Mips related files in the source tree. To ease our understanding and make review easier, could you explain what the current files are responsible for and their relation. I kind of thought that mips32.c already implemented the common functionality shared between different cores, like your proposed mips_common.c, but maybe that's not the case. ./src/target/mips32_dmaacc.c ./src/target/mips32.c ./src/target/mips32_pracc.c ./src/target/mips_ejtag.c ./src/target/mips_m4k.c How would the relations change if you split parts of mips_m4k.c into mips_common.c and added a new mips_m14k.c? Also, we have a fair number of Mips related changes on hold in Gerrit. It would be good if you could check if any of them overlap or conflict with your proposal or if they all are orthogonal. /Andreas
------------------------------------------------------------------------------
_______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
