On 2 February 2015 at 09:59, vichy <[email protected]> wrote: > hi Paul: > > 2015-02-02 15:16 GMT+08:00 Paul Fertser <[email protected]>: >> On Mon, Feb 02, 2015 at 03:01:56PM +0800, vichy wrote: >>> > Please delete the ones that are not needed anymore. >>> >>> How to do that? >>> pressing the abandon button on the gerrit web page, >>> http://openocd.zylin.com/#/c/2525/ >> >> Exactly, yes, Abandon. >> >>> But I found each commit will make a new topic. >> >> Each commit with a Change-Id not seen by Gerrit previously. >> >>> If I want to keep the modification on the same topic, should I hand >>> make the change-id to keep the same as previous one? >> >> No, you should use Git's history rewriting facilities [1] to amend the >> patch accordingly, that way the Change-Id that got initially generated >> by the change will stay in the commit message nicely, unless you >> manually delete it while changing the message. >> >> [1] http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History > I follow your instruction and git --amend to fix previous compile error. > But I get distcheck fail. > > openocd-gerrit-build » mingw32 completed with result SUCCESS > openocd-gerrit-build » zy1000 completed with result SUCCESS > openocd-gerrit-build » linux32 completed with result SUCCESS > openocd-gerrit-build » distcheck completed with result FAILURE > .................................. > > from the console, > http://openocd.zylin.com/jenkins/job/openocd-gerrit-build/TARGET=distcheck/lastBuild/console > , > it says I lost the header file, but I check my patch and gerrit > webpage, both are show the header did successfully pushed in. > > Did I miss anything? > appreciate your kind help, >
you need to add armv8_dpm.h to src/target/Makefile.am noinst_HEADERS. make distcheck checks that the src distribution is complete and working. Cheers Spen ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
