On 3.2.2015 10:08, Andreas Fritiofson wrote:
On Tue, Feb 3, 2015 at 8:22 AM, Tomas Vanek
<tom_...@users.sourceforge.net <mailto:tom_...@users.sourceforge.net>>
wrote:
I contributed a NOR flash driver and config for PSoC 4 chip
family 5 months ago.
I did not mean it as a complaint. I was busy too, so I understand.
Keep up the good work.
Tom
Both the flash driver and config does not influence any other code
so it can not break anything.
We're usually don't demand as much for new drivers or targets that
follow the same pattern as existing code. As you say it can't cause
regressions and it's better to have basic support than none at all.
Things are different for additions that requires changes to
infrastructure or workarounds.
In your case the lack of review is simply due to lack of time and
energy. I apparently reviewed a first version in September and have
not followed that up when new versions were pushed. Due to the volume
of patches that happens all the time and is exactly why contributors
have to ping someone to get attention. Explain to the previous
reviewer that the issues have been taken care of and that the change
is now ready. Just pushing a new version does
not automatically trigger me to re-review it, since for all I know it
could just be a rebase without any improvements.
When the change and all its dependencies has +1 from independent
reviewers/testers and there are no known issues remaining, ask a
maintainer to take a look and submit it. Of course, the maintainer may
have further comments that may require another round.
/Andreas
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
