Hi Tomas. On Tue, 03 Feb 2015 08:22:00 +0100, Tomas Vanek wrote: > I understand that nobody from maintainers or experienced contributors > does not want to give > an important positive review point without trial on real hardware. > > On the other hand what is the risk if you help to accept PSoC 4 support > without testing it?
I sometimes review code I cannot test. When I do so, I read the code slowly, line-by-line. I try to tell myself before I read the line: "I am convinced that this line contains errors and that it will not work." -Of course, I do not always catch the errors, but if the code would be an addition and not a fix, then I think it's worth taking a chance. Love Jens ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
