Hi Antonio, Thank you for your reply and the clarification. I see that only users of relatively old distributions (like CentOS 7) would encounter this.
If there is an easy way how to check for that make feature in autoconf, that would be helpful. Otherwise, IMO it is OK to leave it as is, and make a note about minimum GNU Make version into the Readme. Thank you and regards, Jan On Thu, Feb 11, 2021 at 3:24 PM Antonio Borneo <borneo.anto...@gmail.com> wrote: > Hi Jan, > thanks for reporting it. > > Openocd commit 4fc0f353 uses the shell assignment '!=' that has been > introduced in GNU make in commit > > https://github.com/mirror/make/commit/b34438bee83ee906a23b881f257e684a0993b9b1 > that is just 12 commits after 3.82. The feature was then part of GNU > make 4.0 released on 2013-10-09. > > Today autoconf does not check the version of make. But then there are > other 'make' implementations, not only GNU. Checking for the version > is probably wrong; autoconf should check the 'feature'. > > The commit 4fc0f353 fixes only a warning message. > If GNU make 3.82 is still in use, we can even revert 4fc0f353 and take > time to think about a different implementation. > > Antonio > > On Thu, Feb 11, 2021 at 9:11 AM Jan Matyáš <jmat...@codasip.com> wrote: > > > > Hello all, > > > > This is a question to those well versed in GNU Autotools. > > > > I have noticed that since certain time (Q4/2020 ?), OpenOCD no longer > builds on my CentOS 7 via GNU Make from the package system - version 3.82: > > > > [matyas@pcmatyas riscv-openocd]$ make > > Makefile:5675: *** missing separator. Stop. > > > > A newer version of Make (4.2) works fine for me. > > > > I suspect this is because of a piece of a newer syntax in the Makefile, > not supported by that older version of Make, perhaps introduced in commit > 4fc0f353, however I have not verified that yet. > > > > The question is: Can we enforce a minimum version of Make in the > Autotools build system, so that users are properly notified if their Make > version is insufficient? > > > > Thank you, regards > > Jan > > _______________________________________________ > > OpenOCD-devel mailing list > > OpenOCD-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/openocd-devel >
_______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
