On Thu, Feb 11, 2021 at 6:28 PM Andreas Fritiofson <andreas.fritiof...@gmail.com> wrote: > > > > On Thu, Feb 11, 2021 at 6:09 PM Antonio Borneo <borneo.anto...@gmail.com> > wrote: >> >> On Thu, Feb 11, 2021 at 5:52 PM Andreas Fritiofson >> <andreas.fritiof...@gmail.com> wrote: >> > >> > >> > On Thu, Feb 11, 2021 at 5:47 PM Andreas Fritiofson >> > <andreas.fritiof...@gmail.com> wrote: >> >> >> >> >> >> Is 'shell' a GNU Make only feature that would still have generated a >> >> warning from automake, like the previous 'wildcard'? Otherwise it's the >> >> obvious solution here. >> >> >> > >> > Answering myself... $(shell ls ...) gives the same warning as $(wildcard >> > ...) >> >> Yes, that's why I end up with '!=', after some tests. >> While automake does not complain with '!=', this BSD make syntax is >> still not POSIX approved and not clear if later automake will issue a >> warning here too. >> >> Another option is to have configure to create the list of NEWS-* and >> pass it in a variable for Makefile generation. >> The issue, here (but with very low impact in the day-by-day >> development) is that adding a new NEWS-XX file will require the >> developer to run configure again to let it update Makefile. >> > > You mean like > > diff --git a/Makefile.am b/Makefile.am > index c1de02da0..370a99197 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -42,14 +42,13 @@ if INTERNAL_JIMTCL > AM_CPPFLAGS += -I$(top_srcdir)/jimtcl \ > -I$(top_builddir)/jimtcl > endif > -EXTRA_DIST_NEWS != ls $(srcdir)/NEWS-* > EXTRA_DIST += \ > BUGS \ > HACKING \ > NEWTAPS \ > README.Windows \ > README.OSX \ > - $(EXTRA_DIST_NEWS) \ > + $(srcdir)/NEWS-* \ > Doxyfile.in \ > tools/logger.pl \ > tools/rlink_make_speed_table \ > > ? That certainly seems like the simplest solution. The files are included in > the tarball, I'm not sure what the goal is here if not that. >
No, you cannot have the wildcard NEWS-* in the makefile variable. That's the original reason of the $(wildcard xxx) GNU make function. My idea is instead in http://openocd.zylin.com/6054/ Let's see if it passes distcheck. I only run some simple test, locally Antonio _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
