This is an automated email from Gerrit.

"Antonio Borneo <[email protected]>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/6694

-- gerrit

commit cca703228077b7d96b2c53ffab113782bd4f720c
Author: Antonio Borneo <[email protected]>
Date:   Thu Nov 11 23:11:03 2021 +0100

    openocd: remove last references to debugport_init()
    
    The function debugport_init() has never existed in OpenOCD code,
    but few comments erroneously references it in place of the
    existing function ahbap_debugport_init().
    
    Commit 00dbc185ee56 ("arm_adi_v5: Split ahbap_debugport_init")
    splits the function ahbap_debugport_init() in dap_dp_init() and
    mem_ap_init(), but did not removed all the incorrect comments
    about debugport_init(). Few of such comments has been removed in
    later patches.
    
    Remove the last two comments that reference debugport_init().
    
    Change-Id: Ibd1f125475386e5653340fedf706903a0ee15897
    Signed-off-by: Antonio Borneo <[email protected]>

diff --git a/src/target/adi_v5_swd.c b/src/target/adi_v5_swd.c
index b1240eaa0..9e6ed1b16 100644
--- a/src/target/adi_v5_swd.c
+++ b/src/target/adi_v5_swd.c
@@ -122,7 +122,6 @@ static int swd_connect(struct adiv5_dap *dap)
        int64_t timeout = timeval_ms() + 500;
 
        do {
-               /* Note, debugport_init() does setup too */
                swd->switch_seq(JTAG_TO_SWD);
 
                /* Clear link state, including the SELECT cache. */
diff --git a/src/target/cortex_m.c b/src/target/cortex_m.c
index 6b7b7a5bd..f3234fb13 100644
--- a/src/target/cortex_m.c
+++ b/src/target/cortex_m.c
@@ -2062,7 +2062,6 @@ int cortex_m_examine(struct target *target)
                        }
                }
 
-               /* Leave (only) generic DAP stuff for debugport_init(); */
                armv7m->debug_ap->memaccess_tck = 8;
 
                retval = mem_ap_init(armv7m->debug_ap);

-- 

Reply via email to