[PATCH]: ce9ac7cb16 arm_adi_v5: fix scan-build warning [1/3]

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7010

-- gerrit

commit ce9ac7cb167c4917bdd4efc64220486649f3660a
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Wed Jun 1 18:26:35 2022 +0200

    arm_adi_v5: fix scan-build warning [1/3]
    
    Commit 21f7885d1c2a ("arm_adi_v5: separate ROM table parsing from
    command output [1/3]") introduces a new scan-build warning because
    continues the execution even when dap_get_debugbase() returns
    error. The value of 'apid' can be uninitialized:
    
            5th function call argument is an uninitialized value
    
    Check the return value and quit on error.
    While there, remove the useless initialization of 'dbgbase' that
    was apparently required for the same problem.
    
    Change-Id: Iade26a152925ee0f1bf114ed829b94f7ed5b254f
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Fixes: 21f7885d1c2a ("arm_adi_v5: separate ROM table parsing from command 
output [1/3]")

diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c
index 24de305302..f7b335d95c 100644
--- a/src/target/arm_adi_v5.c
+++ b/src/target/arm_adi_v5.c
@@ -1641,11 +1641,12 @@ static int rtp_ap(const struct rtp_ops *ops, struct 
adiv5_ap *ap)
 {
        int retval;
        uint32_t apid;
-       target_addr_t dbgbase = 0; /* GCC complains can be used uninitialized */
-       target_addr_t invalid_entry;
+       target_addr_t dbgbase, invalid_entry;
 
        /* Now we read ROM table ID registers, ref. ARM IHI 0029B sec  */
        retval = dap_get_debugbase(ap, &dbgbase, &apid);
+       if (retval != ERROR_OK)
+               return retval;
        retval = rtp_ops_mem_ap_header(ops, retval, ap, dbgbase, apid);
        if (retval != ERROR_OK)
                return retval;

--