[PATCH]: ddc4b58b05 arm_adi_v5: fix scan-build warning [3/3]

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7012

-- gerrit

commit ddc4b58b0554ac1be0321b655ceeb9f58b3bac84
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Wed Jun 1 19:21:44 2022 +0200

    arm_adi_v5: fix scan-build warning [3/3]
    
    While scan-build complains that dap_p or ap_num_p could be NULL,
    the current code never passes NULL pointers.
    Add an assert() to silent scan-build and prevent any further use
    of the function with incorrect parameters.
    
    Change-Id: I656810dddcea61e85d85b13efb114f7607ef837c
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c
index 0b11e815d5..52b12cb93f 100644
--- a/src/target/arm_adi_v5.c
+++ b/src/target/arm_adi_v5.c
@@ -1938,6 +1938,8 @@ static const struct jim_nvp nvp_config_opts[] = {
 static int adiv5_jim_spot_configure(struct jim_getopt_info *goi,
                struct adiv5_dap **dap_p, int *ap_num_p, uint32_t *base_p)
 {
+       assert(dap_p && ap_num_p);
+
        if (!goi->argc)
                return JIM_OK;
 

--