This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7184

-- gerrit

commit a6148c1bbfd98637ac6b9cd91f3322b511575a6c
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat Sep 10 14:34:51 2022 +0200

    mips64: remove empty mips_mips64_soft_reset_halt()
    
    The method soft_reset_halt is optional; no need to add an
    empty function.
    
    Remove mips_mips64_soft_reset_halt() and move the TODO comment
    in struct target_type.
    
    Change-Id: Id541a75e7a08645568961d59b73a120c2238701f
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/mips_mips64.c b/src/target/mips_mips64.c
index 449f5a217a..d05b55c462 100644
--- a/src/target/mips_mips64.c
+++ b/src/target/mips_mips64.c
@@ -205,12 +205,6 @@ static int mips_mips64_deassert_reset(struct target 
*target)
        return ERROR_OK;
 }
 
-static int mips_mips64_soft_reset_halt(struct target *target)
-{
-       /* TODO */
-       return ERROR_OK;
-}
-
 static int mips_mips64_single_step_core(struct target *target)
 {
        struct mips64_common *mips64 = target->arch_info;
@@ -1168,7 +1162,7 @@ struct target_type mips_mips64_target = {
 
        .assert_reset = mips_mips64_assert_reset,
        .deassert_reset = mips_mips64_deassert_reset,
-       .soft_reset_halt = mips_mips64_soft_reset_halt,
+       /* TODO: add .soft_reset_halt */
 
        .get_gdb_reg_list = mips64_get_gdb_reg_list,
 

-- 

Reply via email to