[PATCH]: ac045143d4 flash/nor/stm32f2x: Show error message when unprotecting OTP

[gerrit]

This is an automated email from Gerrit.

"Matthijs Kooijman <matth...@stdin.nl>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7615

-- gerrit

commit ac045143d4c7c988b756cccbbbdd9d227811feff
Author: Matthijs Kooijman <matth...@stdin.nl>
Date:   Thu Apr 27 18:34:44 2023 +0200

    flash/nor/stm32f2x: Show error message when unprotecting OTP
    
    Trying to disable OTP write protection by running e.g. `flash protect
    1 0 1 off` would already be rejected with an error code, but that would
    result in a generic "failed setting protection for blocks 0 to 1"
    message. Now a more specific error message is also printed, telling the
    user why it failed.
    
    Change-Id: I6d4974eb0bcd23a0a6cf68ff955d9e59b8b1b06a
    Signed-off-by: Matthijs Kooijman <matth...@stdin.nl>

diff --git a/src/flash/nor/stm32f2x.c b/src/flash/nor/stm32f2x.c
index 6bfeed296e..ea48eb378b 100644
--- a/src/flash/nor/stm32f2x.c
+++ b/src/flash/nor/stm32f2x.c
@@ -676,8 +676,10 @@ static int stm32x_protect(struct flash_bank *bank, int 
set, unsigned int first,
        }
 
        if (stm32x_is_otp(bank)) {
-               if (!set)
+               if (!set) {
+                       LOG_ERROR("OTP protection can only be enabled");
                        return ERROR_COMMAND_ARGUMENT_INVALID;
+               }
 
                return stm32x_otp_protect(bank, first, last);
        }

--