[PATCH]: f2a7f7fb66 driver: assertion in jtag driver when we read register from inactive core

[gerrit]

This is an automated email from Gerrit.

"Kirill Radkin <kirill.rad...@syntacore.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7843

-- gerrit

commit f2a7f7fb661a3cad42be3cda55a6a8000f90856a
Author: Kirill Radkin <kirill.rad...@syntacore.com>
Date:   Wed Aug 2 19:53:38 2023 +0300

    driver: assertion in jtag driver when we read register from inactive core
    
    OpenOCD fails with assert in line 147, add this check to avoud failure
    
    Change-Id: I9d2772f33d992164383b1dc90928fe0f3db477b3
    Signed-off-by: Kirill Radkin <kirill.rad...@syntacore.com>

diff --git a/src/jtag/drivers/driver.c b/src/jtag/drivers/driver.c
index 409b800874..703dd5a98d 100644
--- a/src/jtag/drivers/driver.c
+++ b/src/jtag/drivers/driver.c
@@ -112,8 +112,14 @@ int interface_jtag_add_dr_scan(struct jtag_tap *active, 
int in_num_fields,
        size_t bypass_devices = 0;
 
        for (struct jtag_tap *tap = jtag_tap_next_enabled(NULL); tap; tap = 
jtag_tap_next_enabled(tap)) {
-               if (tap->bypass)
+               if (tap->bypass) {
                        bypass_devices++;
+
+                       if (active == tap) {
+                               LOG_ERROR("Active tap shouldn't be in BYPASS 
mode");
+                               return ERROR_FAIL;
+                       }
+               }
        }
 
        struct jtag_command *cmd = cmd_queue_alloc(sizeof(struct jtag_command));

--