This is an automated email from Gerrit.

"zapb <d...@zapb.de>" just uploaded a new patch set to Gerrit, which you can 
find at https://review.openocd.org/c/openocd/+/8040

-- gerrit

commit d5ac95eaabb4c21c7871b9495fd51328c31b6bbc
Author: Marc Schink <d...@zapb.de>
Date:   Wed Dec 6 18:11:11 2023 +0100

    jtag/core: Use 'bool' data type for 'bypass'
    
    Change-Id: I918fd5ce674e808ad6a96634a11046d2b3f6a05c
    Signed-off-by: Marc Schink <d...@zapb.de>

diff --git a/src/jtag/core.c b/src/jtag/core.c
index 665a932190..e2af6c53d9 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -1049,7 +1049,7 @@ static int jtag_reset_callback(enum jtag_event event, 
void *priv)
 
                /* current instruction is either BYPASS or IDCODE */
                buf_set_ones(tap->cur_instr, tap->ir_length);
-               tap->bypass = 1;
+               tap->bypass = true;
        }
 
        return ERROR_OK;
@@ -1464,7 +1464,7 @@ void jtag_tap_init(struct jtag_tap *tap)
        buf_set_u32(tap->expected_mask, 0, ir_len_bits, tap->ir_capture_mask);
 
        /* TAP will be in bypass mode after jtag_validate_ircapture() */
-       tap->bypass = 1;
+       tap->bypass = true;
        buf_set_ones(tap->cur_instr, tap->ir_length);
 
        /* register the reset callback for the TAP */
diff --git a/src/jtag/drivers/driver.c b/src/jtag/drivers/driver.c
index 409b800874..7732315003 100644
--- a/src/jtag/drivers/driver.c
+++ b/src/jtag/drivers/driver.c
@@ -76,13 +76,13 @@ int interface_jtag_add_ir_scan(struct jtag_tap *active,
 
                if (tap == active) {
                        /* if TAP is listed in input fields, copy the value */
-                       tap->bypass = 0;
+                       tap->bypass = false;
 
                        jtag_scan_field_clone(field, in_fields);
                } else {
                        /* if a TAP isn't listed in input fields, set it to 
BYPASS */
 
-                       tap->bypass = 1;
+                       tap->bypass = true;
 
                        field->num_bits = tap->ir_length;
                        field->out_value = 
buf_set_ones(cmd_queue_alloc(DIV_ROUND_UP(tap->ir_length, 8)), tap->ir_length);
diff --git a/src/jtag/jtag.h b/src/jtag/jtag.h
index 7353104f0a..1d1c495cf1 100644
--- a/src/jtag/jtag.h
+++ b/src/jtag/jtag.h
@@ -131,7 +131,7 @@ struct jtag_tap {
        /** current instruction */
        uint8_t *cur_instr;
        /** Bypass register selected */
-       int bypass;
+       bool bypass;
 
        struct jtag_tap_event_action *event_action;
 

-- 

Reply via email to