[PATCH]: 468204e5e0 helper/log: report target's state in logs

[gerrit]

This is an automated email from Gerrit.

"Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>" just uploaded a new patch 
set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8127

-- gerrit

commit 468204e5e03b69ad3e17ed9399006e063ef4bb86
Author: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>
Date:   Fri Jan 26 16:05:04 2024 +0300

    helper/log: report target's state in logs
    
    `LOG_TARGET_*` macroses report the name of target's state.
    This makes it easyer to analyze the logs.
    Moreover, it's quite common for a user to get an error due to a target
    being running while a command is executed. Reporting target's state at
    the point of failure can help the user understand what went wrong.
    
    Change-Id: I27c293a21f1974479f5e194a8875a99bad3fb7c6
    Signed-off-by: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>

diff --git a/src/helper/log.h b/src/helper/log.h
index ee71bf03f0..eedcfc5856 100644
--- a/src/helper/log.h
+++ b/src/helper/log.h
@@ -135,19 +135,19 @@ extern int debug_level;
 /* Output a log entry that is related to a given target */
 
 #define LOG_TARGET_DEBUG_IO(target, fmt_str, ...) \
-       LOG_DEBUG_IO("[%s] " fmt_str, target_name(target), ##__VA_ARGS__)
+       LOG_DEBUG_IO("[%s]<%s> " fmt_str, target_name(target), 
target_state_name(target), ##__VA_ARGS__)
 
 #define LOG_TARGET_DEBUG(target, fmt_str, ...) \
-       LOG_DEBUG("[%s] " fmt_str, target_name(target), ##__VA_ARGS__)
+       LOG_DEBUG("[%s]<%s> " fmt_str, target_name(target), 
target_state_name(target), ##__VA_ARGS__)
 
 #define LOG_TARGET_INFO(target, fmt_str, ...) \
-       LOG_INFO("[%s] " fmt_str, target_name(target), ##__VA_ARGS__)
+       LOG_INFO("[%s]<%s> " fmt_str, target_name(target), 
target_state_name(target), ##__VA_ARGS__)
 
 #define LOG_TARGET_WARNING(target, fmt_str, ...) \
-       LOG_WARNING("[%s] " fmt_str, target_name(target), ##__VA_ARGS__)
+       LOG_WARNING("[%s]<%s> " fmt_str, target_name(target), 
target_state_name(target), ##__VA_ARGS__)
 
 #define LOG_TARGET_ERROR(target, fmt_str, ...) \
-       LOG_ERROR("[%s] " fmt_str, target_name(target), ##__VA_ARGS__)
+       LOG_ERROR("[%s]<%s> " fmt_str, target_name(target), 
target_state_name(target), ##__VA_ARGS__)
 
 /* general failures
  * error codes < 100

--