[PATCH]: 83422f3b1a gdb_server: fix invalid free

[gerrit]

This is an automated email from Gerrit.

"Jim Paris <jimpa...@meta.com>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/8768

-- gerrit

commit 83422f3b1acef914d391ce2cfd701c493b74e93d
Author: Jim Paris <jimpa...@meta.com>
Date:   Fri Feb 21 12:33:45 2025 -0500

    gdb_server: fix invalid free
    
    `gdb_service_free` calls `free(gdb_port_next)`, so this needs to be an
    allocated string.  Otherwise we trip up detectors like Android's tagged
    pointers.
    
    Change-Id: Ib08ea55a38af4e15c4fbae95f10db0e3684ae1af
    Signed-off-by: Jim Paris <jimpa...@meta.com>

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index c572f392a9..b460ae21a5 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -3898,7 +3898,7 @@ static int gdb_target_add_one(struct target *target)
                                }
                        }
                } else if (strcmp(gdb_port_next, "pipe") == 0) {
-                       gdb_port_next = "disabled";
+                       gdb_port_next = strdup("disabled");
                }
        }
        return retval;

--