Hi Dinesh Arasu,
Am 01.09.25 um 08:16 schrieb dinesh.ar...@microchip.com:
Hi Oleksij Rempel,
As requested, please find below the link to my pull request raised for
the OpenOCD repository:
đź”— PR Link: https://github.com/openocd-org/openocd/pull/44 <https://
github.com/openocd-org/openocd/pull/44>
However, I noticed that the CI checks are not visible under the “Checks”
tab for this PR. Could you please confirm if this is expected or if I
need to perform any additional steps to trigger the build?
Here is a quick pre-review:
- github is only a mirror, PRs are not accepted over this channel.
- all 3 drivers seems to be nearly identical. It will add review and
maintainance overhead. Please use on driver for all if possible. Use
shared code and/or HW version detection. For example some drivers (like
stm32l4x.c) support revision detection.
- no magic numbers/offsets/bits, use defines
- have error handling, nearly all write/read operations may fail.
as I suggested previously, please read:
Please read following documentations before submitting:
https://openocd.org/doc-release/doxygen/patchguide.html
https://openocd.org/doc/doxygen/html/index.html
They describe coding style and where patches should be actually
submitted (not github :)).
