Waiting for confirmation from Angelo, I think it would be better to not add a new git submodule to OpenOCD but to build and distribute eud as a library. Then some glue code in OpenOCD will use the library, if present at build; similarly as libjaylink.
Antonio On Fri, 17 Oct 2025, 10:44 Tommy Murphy, <[email protected]> wrote: > Is this the relevant source code? > > - https://github.com/quic/eud > > If so, then it's GPL v2.0 according to this: > > - https://github.com/quic/eud?tab=readme-ov-file#license > > ------------------------------ > *From:* Antonio Borneo <[email protected]> > *Sent:* Friday, October 17, 2025 8:25:25 AM > *To:* Agnelo Dcosta <[email protected]> > *Cc:* Ashi Gupta <[email protected]>; openocd-devel < > [email protected]> > *Subject:* Re: ERROR:EMBEDDED_FILENAME: for changes in configure.ac > > > > On Fri, 17 Oct 2025, 07:17 Agnelo Dcosta, <[email protected]> > wrote: > > Thoughts on this anyone? > Let me know if any more information/detail is required. > > Thanks, > Agnelo > > > ------------------------------ > *From:* Agnelo Dcosta (QUIC) <[email protected]> > *Sent:* Thursday, October 9, 2025 5:10 PM > *To:* openocd-devel <[email protected]> > *Cc:* Ashi Gupta <[email protected]> > *Subject:* ERROR:EMBEDDED_FILENAME: for changes in configure.ac > > Hi. > > I am trying to add support for a new debug adapter called EUD(Embedded USB > Debug) which is inbuilt into Qualcomm chipsets. > I added the following lines to the <openocd-root-folder>/configure.ac > > *-----------------------x------------------------x-------------------------* > *AS_IF([test "x$enable_eud" != "xno"], [* > * AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac > <http://configure.ac>"], [* > * AX_CONFIG_SUBDIR_OPTION([src/jtag/drivers/eud], > [--enable-subproject-build])* > * ], [* > * AC_MSG_ERROR([Internal eud not found, run either 'git submodule init' > and 'git submodule update' or disable eud with --disable-eud.])* > * ])* > *])* > > *-----------------------x------------------------x-------------------------* > > > Running tools/checkpatch.sh on the patch throws up following error > > *-----------------------x------------------------x-------------------------* > ERROR:EMBEDDED_FILENAME: It's generally not useful to have the filename in > the file > #720: FILE: configure.ac:720: > + AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac"], [ > > *-----------------------x------------------------x-------------------------* > > On line configure.ac:720, the "configure.ac*" *refers to a different > configure.ac file under directory src/jtag/drivers/eud. > Is there some way to get around this error? > > > Hi, > > Checkpatch is not bulletproof and sometimes it screams for nothing. > In the file HACKING is reported how to silent it in specific cases like > this, by adding in the commit message the line > Checkpatch-ignore: EMBEDDED_FILENAME > > In OpenOCD we are going to get rid of submodules and we have deprecated > all of them. > What's the value of adding a new one? > Can the driver be upstream in the OpenOCD code directly? > What's the license of the driver's code? Remember that it should be > compatible with the GPLv2 of OpenOCD, either if embedded, or as submodule > or as link-time external library. > > Regards > Antonio > > >
