Hi.

I am trying to add support for a new debug adapter called EUD(Embedded USB 
Debug) which is inbuilt into Qualcomm chipsets.
I added the following lines to the <openocd-root-folder>/configure.ac
-----------------------x------------------------x-------------------------
AS_IF([test "x$enable_eud" != "xno"], [
  AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac"], [
    AX_CONFIG_SUBDIR_OPTION([src/jtag/drivers/eud], [--enable-subproject-build])
  ], [
    AC_MSG_ERROR([Internal eud not found, run either 'git submodule init' and 
'git submodule update' or disable eud with --disable-eud.])
  ])
])
-----------------------x------------------------x-------------------------


Running tools/checkpatch.sh on the patch throws up following error
-----------------------x------------------------x-------------------------
ERROR:EMBEDDED_FILENAME: It's generally not useful to have the filename in the 
file
#720: FILE: configure.ac:720:
+  AS_IF([test -f "$srcdir/src/jtag/drivers/eud/configure.ac"], [
-----------------------x------------------------x-------------------------

On line configure.ac:720, the "configure.ac" refers to a different configure.ac 
file under directory  src/jtag/drivers/eud.
Is there some way to get around this error?


Thanks,
Agnelo



Reply via email to