My previous patch only fix the BUG that error message display the 
wrong information.
Yes, data should be compared bit by bit, not byte by byte.
And buf_cmp_mask can be called to do the comparation.
I'll provide a patch for this.

PS:
> P.S. It isn't really easy to read source code if it has long lines (>
> 80).
Yes, actually I noticed this problem, and in my afterwards software 
code length should be <= 80.

2009-04-02 



Best Regards, Simon Qian

SimonQian([email protected]) ---- www.SimonQian.com



发件人: Johann F. 
发送时间: 2009-04-02  15:46:28 
收件人: SimonQian 
抄送: openocd-development 
主题: Re: [Openocd-development] xsvf patch 
 
On Thu, 2 Apr 2009 02:49:40 +0800
"SimonQian" <[email protected]> wrote:
> Thank you for the log.
> 
> Is "SDR 32 TDI (00000000) SMASK (FFFFFFFF) TDO (F9604093) MASK (0FFFFFFF)" at 
> line 20 in the svf file?
> According to the log, it fails to verify tdo data at line 20 in the svf file.
> 
> I find a BUG when printing error message when bit_len of IR/DR is >= 32.
> Apply the attached patch, and svf_check_tdo will print the right information.
> 
I tried you patch, but it didn't work and make same error. I changed
svf_check_tdo function so that it checks svf_tdi_buffer and
svf_tdo_buffer bit for bit. Tested, it works. Enclosed patch and my svf
file.
Johann
P.S. It isn't really easy to read source code if it has long lines (>
80).
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to